Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a different error code for UTDs when user was not in the room #4172

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Use a different error code for UTDs when user was not in the room #4172

merged 2 commits into from
Apr 26, 2024

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Apr 19, 2024 •
edited
Loading

Depends on a server that implements MSC4115, such as element-hq/synapse#17104.

Part of element-hq/element-meta#2317

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@uhoreg uhoreg mentioned this pull request Apr 24, 2024
Merged
4 tasks
@uhoreg uhoreg marked this pull request as ready for review April 25, 2024 18:56
@uhoreg uhoreg requested review from a team as code owners April 25, 2024 18:56
@uhoreg uhoreg requested review from andybalaam and richvdh April 25, 2024 18:56
andybalaam
andybalaam approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@uhoreg uhoreg added this pull request to the merge queue Apr 26, 2024
Merged via the queue into matrix-org:develop with commit 64505de Apr 26, 2024
21 checks passed
@uhoreg uhoreg deleted the pre_join_utd branch April 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhoreg @andybalaam