Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove various deprecated methods & re-exports #4125

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Remove various deprecated methods & re-exports #4125

merged 6 commits into from
Mar 25, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 21, 2024 •
edited
Loading

  • Removes deprecated experimentalThreadSupport field on the start client options in favour of threadSupport
  • Removed deprecated method supportsExperimentalThreads on MatrixClient in favour of supportsThreads
  • Remove deprecated method resolveRoomAlias on MatrixClient in favour of getRoomIdForAlias
  • Remove deprecated method setPushActions on MatrixEvent in favour of setPushDetails
  • Remove deprecated method hasAssocation on MatrixEvent in favour of hasAssociation
  • Remove deprecated overload makeRedacted on MatrixEvent, room param is now required
  • Remove deprecated symbol IImageInfo - use ImageInfo instead
  • Remove deprecated symbol IAuthDict - use AuthDict instead
  • Remove deprecated symbol OidcDiscoveryError - use OidcError instead
  • Remove deprecated overload setPowerLevel on MatrixClient, event param no longer specified

Requires matrix-org/matrix-react-sdk#12359

@t3chguy t3chguy requested review from a team as code owners March 21, 2024 17:58
@t3chguy t3chguy added X-Upcoming-Release-Blocker This does not affect the current release cycle but will affect the next one and removed X-Release-Blocker labels Mar 21, 2024
@t3chguy t3chguy self-assigned this Mar 21, 2024
andybalaam
andybalaam approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@t3chguy t3chguy merged commit 85a55c7 into develop Mar 25, 2024
26 of 27 checks passed
@t3chguy t3chguy deleted the t3chguy/remove-depr branch March 25, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Enhancement X-Breaking-Change X-Upcoming-Release-Blocker This does not affect the current release cycle but will affect the next one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam