ElementR| Retry query backup until it works during migration to avoid spurious correption error popup #4113
Conversation
BillCarsonFr
force-pushed
the
valere/element-r/fix_migration_error_with_backup
branch
from
7ee22c4 to
99921dd
Compare
| backupCallDone = true; | ||
| } catch (e) { | ||
| // Retry until successful, use simple constant delay | ||
| await sleep(2000); |
There was a problem hiding this comment.
Figured out it was better to wait a bit, not sure we need exponential backoff though
| const backupInfo = await requestKeyBackupVersion(http); | ||
| let backupCallDone = false; | ||
| let backupInfo: KeyBackupInfo | null = null; | ||
| while (!backupCallDone) { |
There was a problem hiding this comment.
What happens if we are offline or something like that?
There was a problem hiding this comment.
I.e. should we give up eventually?
There was a problem hiding this comment.
As discussed with @richvdh, we might as well block the application until it works.
If we want to give up we would need to catch such errors in LifeCycle#handleLoadSessionFailure and is probably part of a bigger task for proper support of offline mode on web
There was a problem hiding this comment.
Will you do this as part of this change, or separately?
There was a problem hiding this comment.
Not planned for now, needs design and some refactoring
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
BillCarsonFr
deleted the
valere/element-r/fix_migration_error_with_backup
branch
Fixes element-hq/element-web#27196
Checklist
public/exportedsymbols have accurate TSDoc documentation.