Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public rooms post request search params and body #4110

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix public rooms post request search params and body #4110

merged 1 commit into from
Mar 21, 2024

Conversation

ajbura
Copy link
Contributor

@ajbura ajbura commented Mar 14, 2024 •
edited
Loading

post /publicRooms request requires limit and since params in body.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Signed-off-by: Ajay Bura [email protected]

@ajbura ajbura requested a review from a team as a code owner March 14, 2024 13:52
@ajbura ajbura requested review from t3chguy and MidhunSureshR March 14, 2024 13:52
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Mar 14, 2024
@ajbura ajbura changed the title fix public rooms post request search params and body Fix public rooms post request search params and body Mar 19, 2024
t3chguy
t3chguy approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me thanks

@t3chguy t3chguy added this pull request to the merge queue Mar 21, 2024
Merged via the queue into matrix-org:develop with commit dc2d03d Mar 21, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajbura @t3chguy