Add unread marker event type #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support setting the 'marked unread' flag
* await encrypted messages + fix comments Signed-off-by: Timo K <[email protected]> * fix Tests Signed-off-by: Timo K <[email protected]> * fix test Signed-off-by: Timo K <[email protected]> * make sonar happy Signed-off-by: Timo K <[email protected]> --------- Signed-off-by: Timo K <[email protected]>
* ignore memberships of users that are not in the call Signed-off-by: Timo K <[email protected]> * recompute memberships on room member change. Signed-off-by: Timo K <[email protected]> * fix Tests and add test for left member Signed-off-by: Timo K <[email protected]> * fix event type Signed-off-by: Timo K <[email protected]> * fix import desaster Signed-off-by: Timo K <[email protected]> * fix mocks Signed-off-by: Timo K <[email protected]> --------- Signed-off-by: Timo K <[email protected]>
|
I think the PR includes changes from a previous PR of mine. Maybe rebasing on develop? (Or was my PR not yet merged?) |
|
That's very odd, I just merged develop into the branch and pushed. |
florianduros
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support setting the 'marked unread' flag
Checklist
Here's what your changelog entry will look like:
✨ Features