Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit a closed event if the indexeddb is closed by Element #3832

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Don't emit a closed event if the indexeddb is closed by Element #3832

merged 1 commit into from
Oct 25, 2023

Conversation

dhenneke
Copy link
Contributor

@dhenneke dhenneke commented Oct 25, 2023 •
edited by github-actions bot
Loading

Resolve element-hq/element-web#25941

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Type: defect

Here's what your changelog entry will look like:

🐛 Bug Fixes

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect labels Oct 25, 2023
@dhenneke dhenneke marked this pull request as ready for review October 25, 2023 07:49
@dhenneke dhenneke requested a review from a team as a code owner October 25, 2023 07:49
@Johennes Johennes requested review from t3chguy and removed request for florianduros and kerryarchibald October 25, 2023 07:53
t3chguy
t3chguy approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, thanks

@t3chguy t3chguy added this pull request to the merge queue Oct 25, 2023
Merged via the queue into matrix-org:develop with commit c41949d Oct 25, 2023
16 checks passed
@dhenneke dhenneke deleted the nic/feat/fix-close-indexeddb branch November 1, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't refresh the page when the user session is replaced via the module API
2 participants
@dhenneke @t3chguy