Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: Add current version of the rust-sdk and vodozemac #3825

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Element-R: Add current version of the rust-sdk and vodozemac #3825

merged 7 commits into from
Oct 25, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Oct 23, 2023 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Related to element-hq/element-web#26386

Here's what your changelog entry will look like:

✨ Features

  • Element-R: Add current version of the rust-sdk and vodozemac (#3825). Contributed by @florianduros.

@florianduros florianduros mentioned this pull request Oct 23, 2023
Closed
@florianduros florianduros force-pushed the florianduros/elementr/getVersion branch from 75e06fd to aaa28a5 Compare October 23, 2023 15:57
florianduros
florianduros commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask for an exception about the code coverage. I can add a dummy test to see if the old crypto returns null however imo, there is no real gain.

src/crypto/index.ts Outdated Show resolved Hide resolved
@florianduros florianduros marked this pull request as ready for review October 23, 2023 16:26
@florianduros florianduros requested a review from a team as a code owner October 23, 2023 16:26
@richvdh richvdh removed their request for review October 23, 2023 17:02
@florianduros florianduros requested a review from richvdh October 24, 2023 09:06
@florianduros florianduros force-pushed the florianduros/elementr/getVersion branch from 64f6c99 to dc71f6c Compare October 24, 2023 09:57
richvdh
richvdh approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/crypto-api.ts Outdated Show resolved Hide resolved
spec/unit/crypto.spec.ts Outdated Show resolved Hide resolved
spec/unit/rust-crypto/rust-crypto.spec.ts Outdated Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Oct 25, 2023
Merged via the queue into develop with commit 73a8765 Oct 25, 2023
19 checks passed
@florianduros florianduros deleted the florianduros/elementr/getVersion branch October 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @richvdh