Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IsUserMention and IsRoomMention from DEFAULT_OVERRIDE_RULES #3752

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Remove IsUserMention and IsRoomMention from DEFAULT_OVERRIDE_RULES #3752

merged 2 commits into from
Sep 26, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Sep 25, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#26227

Stop overriding intentional mentions rules, so that users can set their preferences

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Remove IsUserMention and IsRoomMention from DEFAULT_OVERRIDE_RULES (#3752). Contributed by @kerryarchibald.

@kerryarchibald kerryarchibald requested a review from a team as a code owner September 25, 2023 23:52
@kerryarchibald kerryarchibald mentioned this pull request Sep 26, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald added this pull request to the merge queue Sep 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Sep 26, 2023
Merged via the queue into develop with commit c672cad Sep 26, 2023
21 checks passed
@kerryarchibald kerryarchibald deleted the kerry/26227/remove-override-intentional-mention-rules branch September 26, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @robintown