Implement getEncryptionInfoForEvent and deprecate getEventEncryptionInfo
#3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2023
richvdh
force-pushed
the
rav/element-r/shields/new_api
branch
from
b515479 to
f358337
Compare
t3chguy
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#25321. This implements a new API which tells the application what sort of "shield" it should display for a given encrypted event.
We have to do it this way because the Rust crypto SDK wants to expose the information in that way (see https://matrix-org.github.io/matrix-rust-sdk/matrix_sdk_common/deserialized_responses/struct.EncryptionInfo.html, and
VerificationState::to_shield_state_lax.The logic here is lifted from the current code in react-sdk, https://github.com/matrix-org/matrix-react-sdk/blob/v3.79.0/src/components/views/rooms/EventTile.tsx#L589-L637.
Here's what your changelog entry will look like:
🦖 Deprecations
getEncryptionInfoForEventand deprecategetEventEncryptionInfo(#3693).