Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit summary update event #3687

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Emit summary update event #3687

merged 4 commits into from
Aug 31, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 30, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#26033

We can not move the setSummary before adding the events to the timeline. Therefore we need a way for applications to know when the summary has been updated so they can update their logic

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@germain-gg germain-gg requested a review from a team as a code owner August 30, 2023 10:12
@germain-gg germain-gg requested review from dbkr and weeman1337 August 30, 2023 10:12
@germain-gg germain-gg mentioned this pull request Aug 30, 2023
Merged
3 tasks
richvdh
richvdh requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more documentation please. What exactly does a RoomEvent.Summary event represent? when exactly is it fired?

@germain-gg germain-gg requested a review from richvdh August 30, 2023 15:37
@germain-gg germain-gg enabled auto-merge August 31, 2023 08:14
richvdh
richvdh reviewed Aug 31, 2023
View reviewed changes
@richvdh
Update RoomSummary event documentation
d190020 
Co-authored-by: Richard van der Hoff <[email protected]>
@germain-gg germain-gg requested a review from richvdh August 31, 2023 08:36
@germain-gg germain-gg added this pull request to the merge queue Aug 31, 2023
Merged via the queue into develop with commit 5ddd453 Aug 31, 2023
@germain-gg germain-gg deleted the germain-gg/emit-summary-event branch August 31, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

room.getJoinedMemberCount() returns incorrect count
2 participants
@germain-gg @richvdh