Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementR: Fix userId parameter usage in CryptoApi#getVerificationRequestsToDeviceInProgress #3611

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jul 20, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

We were using the local userId instead of using the one in the function parameter.


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • ElementR: Fix userId parameter usage in CryptoApi#getVerificationRequestsToDeviceInProgress (#3611). Contributed by @florianduros.

@florianduros florianduros changed the title ElementR: Fix CryptoApi#getVerificationRequestsToDeviceInProgress ElementR: Fix userId parameter usage in CryptoApi#getVerificationRequestsToDeviceInProgress Jul 20, 2023
@florianduros florianduros self-assigned this Jul 20, 2023
@florianduros florianduros marked this pull request as ready for review July 20, 2023 09:44
@florianduros florianduros requested a review from a team as a code owner July 20, 2023 09:44
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!

@florianduros florianduros added this pull request to the merge queue Jul 20, 2023
Merged via the queue into develop with commit ecef9fd Jul 20, 2023
@florianduros florianduros deleted the florianduros/element-r/fix-getVerificationRequestsToDeviceInProgress branch July 20, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants