Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to drop references to user device lists #3610

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Make sure to drop references to user device lists #3610

merged 1 commit into from
Jul 20, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jul 19, 2023 •
edited by github-actions bot
Loading

Empirically, this seems to fix some problems with leaking references to IndexedDB.

Fixes: element-hq/element-web#25817
Fixes: element-hq/element-web#25779 I hope

This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh
Make sure to drop references to user device lists
ecd76a1 
Empirically, this seems to fix some problems with leaking references to
IndexedDB.
@richvdh richvdh added the T-Task Tasks for the team like planning label Jul 19, 2023
@richvdh richvdh marked this pull request as ready for review July 19, 2023 10:57
@richvdh richvdh requested a review from a team as a code owner July 19, 2023 10:57
florianduros
florianduros approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH.

Good catch. Imo, it's a bit alarming to have to manually free the memory.

@richvdh
Copy link
Member Author

richvdh commented Jul 20, 2023

Imo, it's a bit alarming to have to manually free the memory.

It really is. And it makes me wonder how many other places this will be a problem.

@richvdh richvdh added this pull request to the merge queue Jul 20, 2023
Merged via the queue into develop with commit 7dffd8f Jul 20, 2023
@richvdh richvdh deleted the rav/element-r/41_drop_devicelist branch July 20, 2023 09:03
@richvdh richvdh mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg was automatically assigned from matrix-org/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element-R: hang during login Flaky cypress test: Login > logout > should respect logout_redirect_url
2 participants
@richvdh @florianduros