Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: Stub CheckOwnCrossSigningTrust, import cross signing keys and verify local device in bootstrapCrossSigning #3608

Merged
merged 10 commits into from
Jul 25, 2023
Merged

ElementR: Stub CheckOwnCrossSigningTrust, import cross signing keys and verify local device in bootstrapCrossSigning #3608

merged 10 commits into from
Jul 25, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jul 18, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Following element-hq/element-web#25648

  • Deprecate MatrixClient.CheckOwnCrossSigningTrust
  • Stub and deprecate CryptoBackend.CheckOwnCrossSigningTrust
  • Import private cross signing keys from secret storage in bootstrapCrossSigning
  • Verify current device at the end of bootstrapCrossSigning
  • Fire the CryptoEvent.UserTrustStatusChanged event when the cross signing keys are imported.

Here's what your changelog entry will look like:

✨ Features

  • ElementR: Stub CheckOwnCrossSigningTrust, import cross signing keys and verify local device in bootstrapCrossSigning (#3608). Contributed by @florianduros.

@florianduros florianduros changed the title ElementR: Stub CheckOwnCrossSigningTrustOpts, import cross signing keys and verifiy local device in bootstrapCrossSigning ElementR: Stub CheckOwnCrossSigningTrust, import cross signing keys and verifiy local device in bootstrapCrossSigning Jul 18, 2023
@florianduros florianduros force-pushed the florianduros/element-r/checkOwnCrossSigningTrust-bootstrapCrossSigning branch from 172e400 to 2724a05 Compare July 18, 2023 13:45
@florianduros florianduros changed the title ElementR: Stub CheckOwnCrossSigningTrust, import cross signing keys and verifiy local device in bootstrapCrossSigning ElementR: Stub CheckOwnCrossSigningTrust, import cross signing keys and verify local device in bootstrapCrossSigning Jul 18, 2023
@florianduros florianduros mentioned this pull request Jul 18, 2023
Closed
@florianduros florianduros force-pushed the florianduros/element-r/checkOwnCrossSigningTrust-bootstrapCrossSigning branch from 0e2ce00 to 6eb3e99 Compare July 19, 2023 09:57
@florianduros florianduros marked this pull request as ready for review July 19, 2023 16:01
@florianduros florianduros requested a review from a team as a code owner July 19, 2023 16:01
@florianduros florianduros requested review from andybalaam, justjanne and richvdh and removed request for andybalaam and justjanne July 19, 2023 16:01
richvdh
richvdh requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
src/crypto-api.ts Outdated Show resolved Hide resolved
src/rust-crypto/CrossSigningIdentity.ts Outdated Show resolved Hide resolved
src/rust-crypto/CrossSigningIdentity.ts Outdated Show resolved Hide resolved
src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
spec/test-utils/test-data/generate-test-data.py Outdated Show resolved Hide resolved
spec/test-utils/test-data/generate-test-data.py Outdated Show resolved Hide resolved
spec/test-utils/test-data/generate-test-data.py Show resolved Hide resolved
spec/integ/crypto/cross-signing.spec.ts Outdated Show resolved Hide resolved
spec/integ/crypto/cross-signing.spec.ts Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/element-r/checkOwnCrossSigningTrust-bootstrapCrossSigning branch from 141cf8c to 1186cea Compare July 20, 2023 09:05
@florianduros florianduros requested a review from richvdh July 20, 2023 09:10
richvdh
richvdh approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/element-r/checkOwnCrossSigningTrust-bootstrapCrossSigning branch from 6466f31 to 2b22336 Compare July 25, 2023 12:56
richvdh
richvdh reviewed Jul 25, 2023
View reviewed changes
src/crypto-api.ts Outdated Show resolved Hide resolved
richvdh
richvdh requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@florianduros florianduros requested a review from richvdh July 25, 2023 15:40
richvdh
richvdh approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@florianduros florianduros enabled auto-merge July 25, 2023 15:52
@florianduros florianduros mentioned this pull request Jul 25, 2023
Closed
3 tasks
@richvdh
Copy link
Member

richvdh commented Jul 25, 2023

hum, the coverage is too low. Can you add another test somewhere?

@richvdh richvdh disabled auto-merge July 25, 2023 17:03
@richvdh richvdh merged commit 79d4113 into develop Jul 25, 2023
@richvdh richvdh deleted the florianduros/element-r/checkOwnCrossSigningTrust-bootstrapCrossSigning branch July 25, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @richvdh