Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export typed event emitter key types #3597

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Export typed event emitter key types #3597

merged 2 commits into from
Jul 13, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 12, 2023 •
edited by github-actions bot
Loading

Fixes #3506

Here's what your changelog entry will look like:

🐛 Bug Fixes

@t3chguy t3chguy requested a review from a team as a code owner July 12, 2023 15:32
@t3chguy t3chguy requested review from germain-gg and justjanne July 12, 2023 15:32
richvdh
richvdh requested changes Jul 12, 2023
View reviewed changes
src/matrix.ts Outdated Show resolved Hide resolved
@germain-gg germain-gg removed their request for review July 13, 2023 08:00
t3chguy
t3chguy commented Jul 13, 2023
View reviewed changes
src/matrix.ts Outdated Show resolved Hide resolved
@t3chguy t3chguy requested review from richvdh and removed request for justjanne July 13, 2023 11:03
@t3chguy t3chguy enabled auto-merge July 13, 2023 11:05
richvdh
richvdh approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@t3chguy t3chguy added this pull request to the merge queue Jul 13, 2023
Merged via the queue into develop with commit f005984 Jul 13, 2023
@t3chguy t3chguy deleted the t3chguy/export-event-types branch July 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose EmittedEvents subtypes
2 participants
@t3chguy @richvdh