Add new methods to VerificationRequest #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/element-r/16_new_verificationrequest_methods
branch
from
6ac3762 to
addaed6
Compare
richvdh
changed the base branch from
develop
to
rav/element-r/15.1_qrcode_integ_test
richvdh
requested review from
germain-gg and
kerryarchibald
and removed request for
a team
... which requires fewer complicated classes than the existing `qrCodeData`
... to save going via `.channel`
... to avoid the need for `channel`
richvdh
force-pushed
the
rav/element-r/16_new_verificationrequest_methods
branch
from
addaed6 to
4dee362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to pull out an interface from
VerificationRequest, so that I can replace it with a Rust implementation without changes to the application (vector-im/crypto-internal#96).Currently it exposes
channelandqrCodeDatawhich are entire objects of which only one or two fields are used. By adding more specific methods, we can reduce the amount of stuff that has to be implemented considerably.Based on #3439
This change is marked as an internal change (Task), so will not be included in the changelog.