Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: Stub findVerificationRequestDMInProgress and getStoredCrossSigningForUser #3315

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Element-R: Stub findVerificationRequestDMInProgress and getStoredCrossSigningForUser #3315

merged 2 commits into from
Apr 25, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Apr 25, 2023 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Since I'm adding stubbing for the new crypto, I'm asking for an exemption about the code coverage quality gate

Needed in matrix-org/matrix-react-sdk#10671

This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros changed the title Sub findVerificationRequestDMInProgress and getStoredCrossSigningForUser Stub findVerificationRequestDMInProgress and getStoredCrossSigningForUser Apr 25, 2023
@florianduros florianduros added the T-Task Tasks for the team like planning label Apr 25, 2023
This was referenced Apr 25, 2023
Merged
Closed
@florianduros florianduros changed the title Stub findVerificationRequestDMInProgress and getStoredCrossSigningForUser Element-R: Stub findVerificationRequestDMInProgress and getStoredCrossSigningForUser Apr 25, 2023
@florianduros florianduros marked this pull request as ready for review April 25, 2023 14:18
@florianduros florianduros requested a review from a team as a code owner April 25, 2023 14:18
@florianduros florianduros enabled auto-merge April 25, 2023 16:20
@florianduros florianduros mentioned this pull request Apr 25, 2023
Closed
3 tasks
@t3chguy t3chguy disabled auto-merge April 25, 2023 16:52
@t3chguy t3chguy merged commit 73dbd70 into develop Apr 25, 2023
@t3chguy t3chguy deleted the florianduros/feat/add-stub-findVerificationRequestDMInProgress-getStoredCrossSigningForUser branch April 25, 2023 16:52
@richvdh richvdh mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy