Element-R: wire up device lists #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/feat/wire-up-device-list
branch
from
91e1502 to
a4aeaaf
Compare
florianduros
force-pushed
the
florianduros/feat/wire-up-device-list
branch
from
47f45dc to
1c8a1cc
Compare
florianduros
force-pushed
the
florianduros/feat/wire-up-device-list
branch
from
4ebbde4 to
6b291b5
Compare
# Conflicts: # src/crypto-api.ts # src/rust-crypto/rust-crypto.ts
This was referenced Apr 20, 2023
richvdh
requested changes
Apr 21, 2023
florianduros
force-pushed
the
florianduros/feat/wire-up-device-list
branch
from
529b9d4 to
2b57d0e
Compare
florianduros
force-pushed
the
florianduros/feat/wire-up-device-list
branch
from
2b57d0e to
74fae45
Compare
richvdh
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
May 8, 2023
matrix-org/matrix-js-sdk#3272 added a new `CryptoApi.getUserDeviceInfo` method, which also works with rust crypto. Update DeviceListener to use it, thus making many of the cypress tests work on Element Web R.
richvdh
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
May 8, 2023
matrix-org/matrix-js-sdk#3272 added a new `CryptoApi.getUserDeviceInfo` method, which also works with rust crypto. Update DeviceListener to use it, thus making many of the cypress tests work on Element Web R.
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
May 9, 2023
* DeviceListener: use new `getUserDeviceInfo` method matrix-org/matrix-js-sdk#3272 added a new `CryptoApi.getUserDeviceInfo` method, which also works with rust crypto. Update DeviceListener to use it, thus making many of the cypress tests work on Element Web R. * add missing await ... mostly to silence the quality gate
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Jul 31, 2023
* Deprecate MatrixClient::resolveRoomAlias ([\matrix-org#3316](matrix-org#3316)). * add client method to remove pusher ([\matrix-org#3324](matrix-org#3324)). Contributed by @kerryarchibald. * Implement MSC 3981 ([\matrix-org#3248](matrix-org#3248)). Fixes element-hq/element-web#25021. Contributed by @justjanne. * Added `Room.getLastLiveEvent` and `Room.getLastThread`. Deprecated `Room.lastThread` in favour of `Room.getLastThread`. ([\matrix-org#3321](matrix-org#3321)). * Element-R: wire up device lists ([\matrix-org#3272](matrix-org#3272)). Contributed by @florianduros. * Node 20 support ([\matrix-org#3302](matrix-org#3302)). * Fix racing between one-time-keys processing and sync ([\matrix-org#3327](matrix-org#3327)). Fixes element-hq/element-web#25214. Contributed by @florianduros. * Fix lack of media when a user reconnects ([\matrix-org#3318](matrix-org#3318)). * Fix TimelineWindow getEvents exploding if no neigbouring timeline ([\matrix-org#3285](matrix-org#3285)). Fixes element-hq/element-web#25104.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related to element-hq/element-web#24833
The
MatrixClient.downloadKeysandMatrixClient.getStoredDevicesForUsermethods are not available for the new crypto. Following the idea in element-hq/element-web#24833 to add a new methodgetUserDeviceInfoto the crypto API.Instead of changing the existing
downloadKeysandgetStoredDevicesForUserfor both crypto and changing their behaviors, a new methodgetUserDeviceInfois also added to thecrypto-api.This method has the following behavior:
downloadUncachedis attrue(in order to get the devices of theses untracked users)downloadKeysis called (which is calling/keys/querylater)/keys/queryDeviceInfo,QueryDevice,RustSdkCryptoJs.Device) to a unique newDeviceclassHere's what your changelog entry will look like:
✨ Features