Load Thread List with server-side assistance (MSC3856) #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjanne
force-pushed
the
justjanne/feat/thread-list-api-proof-of-concept
branch
from
aec5b7e to
4dfe884
Compare
This was referenced Aug 31, 2022
justjanne
force-pushed
the
justjanne/feat/thread-list-api-proof-of-concept
branch
2 times, most recently
from
c1fd56a to
c5aff2d
Compare
justjanne
force-pushed
the
justjanne/feat/thread-list-api-proof-of-concept
branch
2 times, most recently
from
a3be071 to
ba48a6f
Compare
justjanne
changed the title
justjanne
force-pushed
the
justjanne/feat/thread-list-api-proof-of-concept
branch
2 times, most recently
from
d5e339b to
662fe0b
Compare
robintown
reviewed
Sep 28, 2022
robintown
approved these changes
Sep 28, 2022
justjanne
force-pushed
the
justjanne/feat/thread-list-api-proof-of-concept
branch
from
e3aafbc to
fbb39af
Compare
This was referenced Oct 5, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Oct 29, 2022
* Changes the `uploadContent` API, kills off `request` and `browser-request` in favour of `fetch`, removed callback support on a lot of the methods, adds a lot of tests. ([\matrix-org#2719](matrix-org#2719)). Fixes matrix-org#2415 and matrix-org#801. * Remove deprecated `m.room.aliases` references ([\matrix-org#2759](matrix-org#2759)). Fixes element-hq/element-web#12680. * Remove node-specific crypto bits, use Node 16's WebCrypto ([\matrix-org#2762](matrix-org#2762)). Fixes matrix-org#2760. * Export types for MatrixEvent and Room emitted events, and make event handler map types stricter ([\matrix-org#2750](matrix-org#2750)). Contributed by @stas-demydiuk. * Use even more stable calls to `/room_keys` ([\matrix-org#2746](matrix-org#2746)). * Upgrade to Olm 3.2.13 which has been repackaged to support Node 18 ([\matrix-org#2744](matrix-org#2744)). * Fix `power_level_content_override` type ([\matrix-org#2741](matrix-org#2741)). * Add custom notification handling for MSC3401 call events ([\matrix-org#2720](matrix-org#2720)). * Add support for unread thread notifications ([\matrix-org#2726](matrix-org#2726)). * Load Thread List with server-side assistance (MSC3856) ([\matrix-org#2602](matrix-org#2602)). * Use stable calls to `/room_keys` ([\matrix-org#2729](matrix-org#2729)). Fixes element-hq/element-web#22839. * Fix POST data not being passed for registerWithIdentityServer ([\matrix-org#2769](matrix-org#2769)). Fixes matrix-org/element-web-rageshakes#16206. * Fix IdentityPrefix.V2 containing spurious `/api` ([\matrix-org#2761](matrix-org#2761)). Fixes element-hq/element-web#23505. * Always send back an httpStatus property if one is known ([\matrix-org#2753](matrix-org#2753)). * Check for AbortError, not any generic connection error, to avoid tightlooping ([\matrix-org#2752](matrix-org#2752)). * Correct the dir parameter of MSC3715 ([\matrix-org#2745](matrix-org#2745)). Contributed by @dhenneke. * Fix sync init when thread unread notif is not supported ([\matrix-org#2739](matrix-org#2739)). Fixes element-hq/element-web#23435. * Use the correct sender key when checking shared secret ([\matrix-org#2730](matrix-org#2730)). Fixes element-hq/element-web#23374.
| @@ -711,6 +752,63 @@ describe("MatrixClient event timelines", function() { | |||
| }); | |||
|
|
|||
| describe("getLatestTimeline", function() { | |||
There was a problem hiding this comment.
We should also add some tests for the thread scenarios added to getLatestTimeline(...) in this PR.
It was originally only intended for the main live timeline (room.getUnfilteredTimelineSet(...)) and our only usage in the SDK from room.refreshLiveTimeline(...) is still for that purpose
| @@ -5438,27 +5444,36 @@ export class MatrixClient extends TypedEventEmitter<EmittedEvents, ClientEventHa | |||
| * @return {Promise} Resolves: | |||
| * {@link module:models/event-timeline~EventTimeline} timeline with the latest events in the room | |||
| */ | |||
| public async getLatestTimeline(timelineSet: EventTimelineSet): Promise<EventTimeline> { | |||
| public async getLatestTimeline(timelineSet: EventTimelineSet): Promise<Optional<EventTimeline>> { | |||
There was a problem hiding this comment.
This function is expected to always return an EventTimeline and was introduced during a time where getEventTimeline(...) always returned a timeline as well, see #2299. I see that this PR is just updating the signature to match what getEventTimeline(...) can do to us though.
This will break the assumptions in room.refreshLiveTimeline()
For reference, we're also thinking about how to make getEventTimeline(...) play nicely here for another bug scenario in #2521 (comment). So there probably isn't any action here besides sparing a thought if you can think of a good solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Enhancement
Related: element-hq/element-web#21877
Related: element-hq/element-web#21911
Here's what your changelog entry will look like:
✨ Features