Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch promise errors in degradable to properly fallback from IndexedDBStore to MemoryStore (fixes #2384) #2385

Merged
merged 1 commit into from
May 19, 2022

Conversation

schmop
Copy link
Contributor

@schmop schmop commented May 19, 2022

Signed-off-by: Lars Richard [email protected]

Fixes #2384

Catch promise errors in degradable to properly fallback from IndexedDBStore to MemoryStore when it encounters an error


Here's what your changelog entry will look like:

🐛 Bug Fixes

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, I'll make sure it makes it into the next release which is currently in RC

@t3chguy t3chguy merged commit 81d884f into matrix-org:develop May 19, 2022
@MadLittleMods MadLittleMods changed the title Catch promise errors in degradable (fixes #2384) Catch promise errors in degradable to properly fallback from IndexedDBStore to MemoryStore (fixes #2384) May 19, 2022
t3chguy pushed a commit that referenced this pull request May 20, 2022
Co-authored-by: Lars Richard <[email protected]>
(cherry picked from commit 81d884f)
t3chguy added a commit that referenced this pull request May 20, 2022
Co-authored-by: Lars Richard <[email protected]>
(cherry picked from commit 81d884f)

Co-authored-by: schmop <[email protected]>
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Jun 7, 2022
* Convert `getLocalAliases` to a stable API call ([\matrix-org#2402](matrix-org#2402)).
* Fix request, crypto, and bs58 imports ([\matrix-org#2414](matrix-org#2414)). Fixes matrix-org#2415.
* Update relations after every decryption attempt ([\matrix-org#2387](matrix-org#2387)). Fixes element-hq/element-web#22258. Contributed by @weeman1337.
* Fix degraded mode for the IDBStore and test it ([\matrix-org#2400](matrix-org#2400)). Fixes matrix-org/element-web-rageshakes#13170.
* Don't cancel SAS verifications if `ready` is received after `start` ([\matrix-org#2250](matrix-org#2250)).
* Prevent overlapping sync accumulator persists ([\matrix-org#2392](matrix-org#2392)). Fixes vector-im/element-web#21541.
* Fix behaviour of isRelation with relation m.replace for state events ([\matrix-org#2389](matrix-org#2389)). Fixes element-hq/element-web#22280.
* Fixes matrix-org#2384 ([\matrix-org#2385](matrix-org#2385)). Fixes undefined/matrix-js-sdk#2384. Contributed by @schmop.
* Ensure rooms are recalculated on re-invites ([\matrix-org#2374](matrix-org#2374)). Fixes element-hq/element-web#22106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Degration of indexeddb to MemoryStore does not work anymore
2 participants