Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change _unstable_getSharedRooms to _unstable_getMutualRooms #2271

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

ShadowJonathan
Copy link
Contributor

@ShadowJonathan ShadowJonathan commented Apr 2, 2022

In accordance with changes to matrix-org/matrix-spec-proposals#2666, renaming from "shared" to "mutual".

This updates #1417
This blocks matrix-org/matrix-react-sdk#4897

Notes: Change _unstable_getSharedRooms to _unstable_getMutualRooms and update unstable URL.
Type: task

Signed-off-by: Jonathan de Jong <[email protected]>


This change is marked as an internal change (Task), so will not be included in the changelog.

@ShadowJonathan ShadowJonathan requested a review from a team as a code owner April 2, 2022 15:23
@github-actions github-actions bot added the T-Task Tasks for the team like planning label Apr 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #2271 (02e423b) into develop (106f7be) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2271      +/-   ##
===========================================
- Coverage    58.96%   58.95%   -0.02%     
===========================================
  Files           91       91              
  Lines        16326    16329       +3     
  Branches      3766     3767       +1     
===========================================
  Hits          9627     9627              
- Misses        6699     6702       +3     
Impacted Files Coverage Δ
src/client.ts 38.10% <0.00%> (-0.05%) ⬇️

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note also that this sort of rename is not required in order for the MSC to pass the implementation check. The name of the feature is less important than the function of it.

src/client.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
@ShadowJonathan
Copy link
Contributor Author

ShadowJonathan commented Apr 12, 2022

(Synapse (re)implementation will happen concurrently)

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit 54661cc into matrix-org:develop Apr 12, 2022
@ShadowJonathan ShadowJonathan deleted the shared-to-mutual branch August 2, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants