Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up some VoIP code #1821

Merged
merged 18 commits into from
Aug 3, 2021
Merged

Clean-up some VoIP code #1821

merged 18 commits into from
Aug 3, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Aug 2, 2021 •
edited
Loading

For the review: Please review this carefully, as it could lead to regressions. The pull request should be reviewable commit by commit

@SimonBrandner
localAVStream -> localUsermediaStream
1e281f6 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
screenSharingStream -> localScreenSharingStream
aae8f1c 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Remove config as it wasn't used
eac77a6 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Merge remote-tracking branch 'upstream/develop' into task/cleanup
8b0c4a0 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Make localScreenSharingStream into a getter
bc07ad5 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Make localUsermediaStream into a getter
4631cd1 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Remove unused mute state stuff
dbb0f66 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Standardise screensharing casing
0313483 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Fix typos
f4e985b 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Move things we can into a switch statement
7e0aeb4 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Extract type into a variable
904071e 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Extract weSentTheEvent into a variable
dd3c53e 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Make a few things into one liners
5b13785 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Improve styling a bit
ac2c091 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Rename for consistency
fee6a96 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Move for better organization
b93e792 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Improve wording
7484e3c 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Rename so that VS Code spell checker shutsup
775c346 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner marked this pull request as ready for review August 3, 2021 08:12
@dbkr dbkr self-requested a review August 3, 2021 08:54
@dbkr dbkr added the T-Task Tasks for the team like planning label Aug 3, 2021
dbkr
dbkr approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible as far as I can tell - thanks!

@dbkr dbkr merged commit be8ecce into matrix-org:develop Aug 3, 2021
@SimonBrandner SimonBrandner deleted the task/cleanup branch August 3, 2021 12:20
This was referenced Aug 8, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBrandner @dbkr