Perform crypto store operations directly after transaction #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we wait until after the device list writes to the crypto store before marking thing as clean. This is particularly important for the error path, as the write to the crypto store can fail. Part of element-hq/element-web#12207
A few of the crypto store backend paths were missing try / catch wrappers to abort the transaction if the inner callback throws.
At least on Safari but perhaps other browsers as well, you must perform IndexedDB operations in the same JS task as you start the transaction. As a concrete example, you cannot open the transaction and await some promise before actually using it. This fixes the crypto store to meet this requirement. Fixes element-hq/element-web#12207
bwindels
approved these changes
Feb 27, 2020
Well, Yes, just awaiting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on Safari but perhaps other browsers as well, you must perform
IndexedDB operations in the same JS task as you start the transaction. As a
concrete example, you cannot open the transaction and await some promise before
actually using it.
This fixes the crypto store to meet this requirement.
Fixes element-hq/element-web#12207