Disable CallKit in China (#1941) #578
Conversation
Signed-off-by: Aaron Raimist <[email protected]>
There was a problem hiding this comment.
Thanks @aaronraimist. That change will be greatly appreciated.
It is not mentioned yet anywhere in matrix iOS contribution guides but could you please update CHANGES.rst?
| // CallKit currently illegal in China | ||
| // https://github.com/vector-im/riot-ios/issues/1941 | ||
|
|
||
| return ![NSLocale.currentLocale.countryCode isEqual: @"CN"]; |
There was a problem hiding this comment.
https://stackoverflow.com/a/51319158 checks also "CHN". We could do the same.
There was a problem hiding this comment.
It seems like they are all two letters as least as far as iOS is concerned.
Signed-off-by: Aaron Raimist <[email protected]>
Signed-off-by: Aaron Raimist <[email protected]>
|
Should be good to go |
If |
|
Yeah I was just responding to element-hq/element-ios#1941 which talked about adding a new string and disabling it in a different way so it would still show that section of the settings but explain that it can't be enabled legally. |
Fixes element-hq/element-ios#1941
Fixes element-hq/element-ios#1891
I decided to just disable in the same way that we disable it if you are on iOS 9.
I think it would be pointless to display the grayed out CallKit settings to Chinese users and add a new string that says basically sorry we can't legally give you this feature.