Room summary computation: Use the matrix room summaries algo even if LL is off #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the same room names for #design:matrix.org or #freenode_#vuc:matrix.org
…room summaries Note: Using room alias for name has been accepted in the spec
SBiOSoftWhare
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, computations of name, avatar and members count use the same code if matrix room summary is available or not, which depends on LL activation.
Even invitations share now the same code too.
Along development, there was some update in the spec. The goal is to have same room names in Riot as before. You can see spec updates in comments updates along commits.
Commits can be reviewed one by one.
Should fix unexpected empty rooms (element-hq/element-ios#2020).