Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MXRestClient: Add [MXRestClient eventWithEventId:] and [MXRestClient … #469

Merged
merged 3 commits into from
Mar 12, 2018

Conversation

manuroe
Copy link
Contributor

@manuroe manuroe commented Mar 9, 2018

…eventWithEventId:inRoom:] methods

and use the last one to improve the handling of the redaction of an event so old that we do not have it the local store.

element-hq/element-ios#1730

manuroe added 2 commits March 9, 2018 11:03
…eventWithEventId:inRoom:] methods

and use the last one to improve the handling of the redaction of an event so old that we do not have it the local store.

element-hq/element-ios#1730
@manuroe manuroe requested a review from giomfo March 9, 2018 10:05
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment

@@ -663,8 +663,8 @@ - (void)handleRedaction:(MXEvent*)redactionEvent
{
// Use a /context request to check whether the redacted event is a state event or not.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should be updated here

…eventWithEventId:inRoom:] methods

Fix Giom's remark
@manuroe manuroe merged commit 7db03b6 into develop Mar 12, 2018
@manuroe manuroe deleted the riot_1730 branch March 12, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants