Crypto: Rework device list tracking logic #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crypto and its store can be reused just after [MXCrypto close]. It is useful for tests but it can also fix potential crash the app does a logout.
Update testMultipleDownloadKeys to check deviceTrackingStatus in store
Disable testClearCache because it became impossible to simulate UISI
Manage auto update of MXRealmCryptoStore realm db schema.
|
LGTM |
Update testMultipleDownloadKeys to not put alice and bob in the same. Else, they will download their keys
Add MXDeviceTrackingStatusUnreachableServer. Factorise the MXDeviceListOperation creation in one place to better handler errors. Do not try to download again devices for users in MXDeviceTrackingStatusUnreachableServer state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to matrix-org/matrix-js-sdk#425.