Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media Authentication support MSC 3916 #1871

Merged
merged 8 commits into from
Jul 5, 2024
Merged

Media Authentication support MSC 3916 #1871

merged 8 commits into from
Jul 5, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 5, 2024

This PR adds support for authenticated media APIs as of MSC 3916

@Velin92 Velin92 requested a review from pixlwave July 5, 2024 14:12
pixlwave
pixlwave approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of small thoughts I've just had added inline.

Also, we still need a changelog file in the old App/SDK 🫠

MatrixSDK/MXRestClient.h Outdated Show resolved Hide resolved
MatrixSDK/Utils/Media/MXMediaLoader.h Outdated Show resolved Hide resolved
MatrixSDK/MXRestClient.h Outdated Show resolved Hide resolved
MatrixSDK/MXRestClient.m Outdated Show resolved Hide resolved
MatrixSDK/Utils/Media/MXMediaManager.m Outdated Show resolved Hide resolved
@Velin92 Velin92 merged commit 1c4b3f5 into develop Jul 5, 2024
3 checks passed
@Velin92 Velin92 deleted the mauroromito/content_auth_APIs branch July 5, 2024 16:07
@NicolasBuquet NicolasBuquet mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @pixlwave