Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more crypto logs #1724

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Add more crypto logs #1724

merged 1 commit into from
Feb 24, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Feb 24, 2023

Relates to https://github.com/vector-im/crypto-internal/issues/21

Based on rageshake investigations, curb existing logs, but adding more detail to some, and removing other

@Anderas Anderas requested review from a team and pixlwave and removed request for a team February 24, 2023 09:14
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 37.40% // Head: 37.40% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a328347) compared to base (395bb44).
Patch coverage: 23.52% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1724   +/-   ##
========================================
  Coverage    37.40%   37.40%           
========================================
  Files          612      612           
  Lines        96165    96171    +6     
  Branches     41587    41588    +1     
========================================
+ Hits         35967    35973    +6     
+ Misses       59143    59142    -1     
- Partials      1055     1056    +1     
Impacted Files Coverage Δ
MatrixSDK/Crypto/MXCryptoV2.swift 14.04% <ø> (+0.07%) ⬆️
...trixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift 22.42% <10.00%> (-0.18%) ⬇️
...o/Algorithms/RoomEvent/MXRoomEventEncryption.swift 80.71% <42.85%> (-2.38%) ⬇️
MatrixSDK/Crypto/Algorithms/Olm/MXOlmDecryption.m 43.06% <0.00%> (-3.83%) ⬇️
...yncResponseFileStore/MXSyncResponseFileStore.swift 72.95% <0.00%> (-1.54%) ⬇️
MatrixSDK/Crypto/MXOlmDevice.m 80.95% <0.00%> (-0.65%) ⬇️
...Data/Store/MXRealmCryptoStore/MXRealmCryptoStore.m 68.79% <0.00%> (-0.22%) ⬇️
MatrixSDK/MXSession.m 39.97% <0.00%> (+0.08%) ⬆️
...SDK/Crypto/Verification/MXKeyVerificationManager.m 53.98% <0.00%> (+0.35%) ⬆️
MatrixSDK/Space/MXSpaceNotificationCounter.swift 71.42% <0.00%> (+1.86%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit 29e3713 into develop Feb 24, 2023
@Anderas Anderas deleted the andy/crypto_logs branch February 24, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants