Control CryptoSDK via feature flag #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/crypto_feature
branch
from
85cf540 to
87f739f
Compare
Anderas
requested review from
a team and
nimau
and removed request for
a team
Anderas
force-pushed
the
andy/crypto_feature
branch
from
87f739f to
56f12fe
Compare
Codecov ReportBase: 37.36% // Head: 17.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1719 +/- ##
============================================
- Coverage 37.36% 17.62% -19.74%
============================================
Files 612 612
Lines 96120 96130 +10
Branches 41542 40355 -1187
============================================
- Hits 35915 16945 -18970
- Misses 59154 78675 +19521
+ Partials 1051 510 -541
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
MXCryptoV2Featureprotocol, implemented in the main app, which controls whether rust-based crypto sdk is enabled or not.This allows more nuanced approach to enabling the feature (incl. at runtime), for instance by combining manual opt-in and remote feature flags.