Enable Crypto SDK for production #1708
Conversation
Anderas
force-pushed
the
andy/crypto_sdk
branch
from
0d87bc1 to
6443c32
Compare
Anderas
requested review from
a team and
pixlwave
and removed request for
a team
| @@ -45,7 +45,7 @@ Pod::Spec.new do |s| | |||
| ss.dependency 'OLMKit', '~> 3.2.5' | |||
| ss.dependency 'Realm', '10.27.0' | |||
| ss.dependency 'libbase58', '~> 0.1.4' | |||
| ss.dependency 'MatrixSDK/CryptoSDK' | |||
| ss.dependency 'MatrixSDKCrypto', '0.2.0', :configurations => ["DEBUG", "RELEASE"], :inhibit_warnings => true | |||
There was a problem hiding this comment.
I dont know if this is a coocapods bug, but I have to keep the configuration section in (even though it includes all configurations) if I also have the inhibit_warnings in
There was a problem hiding this comment.
Odd, but if that's how it has to be its not going to bother anyone :)
| @@ -45,7 +45,7 @@ Pod::Spec.new do |s| | |||
| ss.dependency 'OLMKit', '~> 3.2.5' | |||
| ss.dependency 'Realm', '10.27.0' | |||
| ss.dependency 'libbase58', '~> 0.1.4' | |||
| ss.dependency 'MatrixSDK/CryptoSDK' | |||
| ss.dependency 'MatrixSDKCrypto', '0.2.0', :configurations => ["DEBUG", "RELEASE"], :inhibit_warnings => true | |||
There was a problem hiding this comment.
Odd, but if that's how it has to be its not going to bother anyone :)
Anderas
force-pushed
the
andy/crypto_sdk
branch
from
6443c32 to
c56a32f
Compare
Codecov ReportBase: 37.29% // Head: 37.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1708 +/- ##
===========================================
+ Coverage 37.29% 37.35% +0.05%
===========================================
Files 611 612 +1
Lines 95876 95950 +74
Branches 41445 41465 +20
===========================================
+ Hits 35757 35839 +82
+ Misses 59069 59035 -34
- Partials 1050 1076 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This is a big moment !
MatrixSDKCryptopod to 0.2.0 which is now production ready (though still considered beta)isCryptoSDKAvailable, which makes crypto 2.0 / SDK visible as a labs flag