Fix JSONDictionary of keys query responses #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/query_fixes
branch
from
bcd5e6f to
fb0815f
Compare
Anderas
requested review from
a team and
flescio
and removed request for
a team
Anderas
force-pushed
the
andy/query_fixes
branch
from
fb0815f to
fa7334b
Compare
Anderas
commented
Feb 2, 2023
| @@ -35,7 +35,7 @@ public extension MXRestClient { | |||
| failure: @escaping (_ error: NSError?) -> Void) -> MXHTTPOperation { | |||
|
|
|||
| // Do not chunk if not needed | |||
| if users.count < chunkSize { | |||
| if users.count <= chunkSize { | |||
There was a problem hiding this comment.
Naughty naughty. Will write a test for this in a separate PR as it requires some integration test stubbing
Codecov ReportBase: 17.40% // Head: 37.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1707 +/- ##
============================================
+ Coverage 17.40% 37.32% +19.91%
============================================
Files 610 611 +1
Lines 95428 95876 +448
Branches 40198 41447 +1249
============================================
+ Hits 16613 35785 +19172
+ Misses 78309 59043 -19266
- Partials 506 1048 +542
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading user keys via
keys/querywe sometimes usedownloadByChunksmethod that makes several HTTP requests and combines the result into a singleMXKeysQueryResponse. The Crypto V2 relies on getting the value of this response viaJSONDictionaryproperty, however this property was previously just returning whatever initial value was used to create it, and is nil when combining multiple responses together.To solve this we cannot rely on stored property but rather have to compute the
JSONDictionaryout of the current values of the response. Additionally there was a minor bug indownloadByChunksthat would trigger this problem even if we are downloading exactly chunk-sized number of users