Import legacy backup in batches with progress #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/backup_fixes
branch
from
79bd84c to
46a6764
Compare
Anderas
changed the title
Anderas
requested review from
a team and
Velin92
and removed request for
a team
Codecov ReportBase: 37.51% // Head: 17.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1701 +/- ##
============================================
- Coverage 37.51% 17.43% -20.08%
============================================
Files 609 610 +1
Lines 95165 95234 +69
Branches 41297 40122 -1175
============================================
- Hits 35701 16607 -19094
- Misses 58423 78122 +19699
+ Partials 1041 505 -536
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import room backups in batches and report progress continuously.
Note that even with this change memory growns linearly during import (albeit with a smaller slope), which means we are either leaking some memory or filling up in-memory cache somewhere in the crypto layer. Either way this should make imports slightly less memory hungry, and compute the progress regardless.
This PR also contains some small fixes for crypto v2 (logs + tracked users optimization)