Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance PollProtocol for poll history (PSG-1043) #1691

Merged
merged 13 commits into from
Jan 24, 2023
Merged

Enhance PollProtocol for poll history (PSG-1043) #1691

merged 13 commits into from
Jan 24, 2023

Conversation

alfogrillo
Copy link
Contributor

Description

This PR:

  • Enhance the PollProtocol to include more information for a poll (the id of the poll started event, the start date). This information is needed to build a poll history.
  • Fixes a potential reference cycle given that the PollAggregator's delegate wasn't weak
  • Refactors a bit the PollAggregator to remove unwrapped properties.

@alfogrillo alfogrillo requested review from a team and nimau and removed request for a team January 23, 2023 14:55
@alfogrillo alfogrillo mentioned this pull request Jan 23, 2023
Merged
nimau
nimau approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@alfogrillo alfogrillo merged commit 5e6fb10 into develop Jan 24, 2023
@alfogrillo alfogrillo deleted the alfogrillo/fetch_poll_history branch January 24, 2023 15:31
Anderas added a commit that referenced this pull request Feb 2, 2023
@Anderas
Revert "Merge pull request #1691 from matrix-org/alfogrillo/fetch_pol…
6b358a0 
…l_history"

This reverts commit 5e6fb10, reversing
changes made to 10c420c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimau nimau nimau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfogrillo @nimau