Batch migrate olm and megolm sessions #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/large_accounts
branch
from
69bd632 to
a8ace46
Compare
Anderas
requested review from
a team and
Velin92
and removed request for
a team
Anderas
force-pushed
the
andy/large_accounts
branch
3 times, most recently
from
b3255d4 to
f42240e
Compare
Anderas
force-pushed
the
andy/large_accounts
branch
from
f42240e to
747d10f
Compare
Anderas
force-pushed
the
andy/large_accounts
branch
from
747d10f to
f1b4b7a
Compare
Velin92
approved these changes
Jan 23, 2023
Velin92
reviewed
Jan 23, 2023
| log.debug("Migrating olm sessions in batches") | ||
|
|
||
| // How much does migration of olm vs megolm sessions contribute to the overall progress | ||
| let olmToMegolmProgressRatio = 0.25 |
There was a problem hiding this comment.
We discussed this on element but yeah this could be a computed value of olm / (olm + megolm)
Extract room event encryption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating large accounts from libolm to rust (100K + room keys) the application consumes a lot of memory, first by fetching data from realm (all at once), then converting to rust objects, and then migrating to rust crypto store. For these large accounts we may even run out of memory before the migration completes.
To solve this add new methods to crypto store that can enumerate batches of sessions (with configurable batch size) that are wrapped in
autoreleasepool. During migration we continuously enumerate olm and megolm sessions, and no matter how many there are, we can keep a mostly constant memory footprint.Due to the number of work necessary, migration now becomes an asynchronous task that needs to report its own progress. This is eventually tied into existing MXSessionStartupProgress and displayed on the loading page