Verification request and QR listener in Crypto V2 #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/verification_changes
branch
from
57ec49a to
1a8c46e
Compare
Anderas
requested review from
a team and
alfogrillo
and removed request for
a team
Anderas
force-pushed
the
andy/verification_changes
branch
2 times, most recently
from
4184f5c to
574641d
Compare
Anderas
force-pushed
the
andy/verification_changes
branch
from
574641d to
a93c146
Compare
alfogrillo
approved these changes
Dec 15, 2022
Comment on lines
34
to
40
| if state != oldValue { | ||
| log.debug("\(oldValue.description) -> \(state.description)") | ||
|
|
||
| DispatchQueue.main.async { | ||
| NotificationCenter.default.post(name: .MXKeyVerificationRequestDidChange, object: self) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if state != oldValue { | |
| log.debug("\(oldValue.description) -> \(state.description)") | |
| DispatchQueue.main.async { | |
| NotificationCenter.default.post(name: .MXKeyVerificationRequestDidChange, object: self) | |
| } | |
| } | |
| guard state != oldValue else { return } | |
| log.debug("\(oldValue.description) -> \(state.description)") | |
| DispatchQueue.main.async { | |
| NotificationCenter.default.post(name: .MXKeyVerificationRequestDidChange, object: self) | |
| } |
| qrCode.state | ||
| private(set) var state: MXQRCodeTransactionState = .unknown { | ||
| didSet { | ||
| if state != oldValue { |
There was a problem hiding this comment.
Same guard consideration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate verification signalling which exposes state stream for
VerificationRequestandQrCodethe same way as was previously done forSAS. This makes it possible to completely removeupdatePendingVerificationmethod which manually compares the state of verification objects.There are a few things that this PR does not address yet and will be resolved in future PR:
actortype to make concurrency more rigorousprocessOutgoingRequestsfrom multiple places also makes it less obvious when and how this should be called (after sync, after decrypting events, ...)