Import progress for room keys with Crypto V2 #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
alfogrillo
and removed request for
a team
Anderas
force-pushed
the
andy/large_backups
branch
from
e7f7008 to
e5dd8d3
Compare
Codecov ReportBase: 16.02% // Head: 36.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1637 +/- ##
============================================
+ Coverage 16.02% 36.15% +20.12%
============================================
Files 583 583
Lines 92528 92556 +28
Branches 39030 40240 +1210
============================================
+ Hits 14830 33463 +18633
+ Misses 77213 58088 -19125
- Partials 485 1005 +520
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alfogrillo
approved these changes
Nov 15, 2022
| @@ -362,6 +382,10 @@ class MXCryptoKeyBackupEngine: NSObject, MXKeyBackupEngine { | |||
| return try backup.exportRoomKeys(passphrase: passphrase) | |||
| } | |||
|
|
|||
| func importProgress() -> Progress? { | |||
| return activeImportProgress | |||
There was a problem hiding this comment.
Suggested change
| return activeImportProgress | |
| activeImportProgress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up room keys into batches of 1000 when importing, and ensure to decrypt + import within
autoreleasepool. This ensures we do not run out of memory when importing large key backups.Additionally expose
importProgressproperty, analogous to existingbackupProgress, that can be used by any UI.Tested by importing 1,000,000 keys on a device, which does grow the memory footprint considerably, but still slower than without the
autoreleasepooland batching. The initial spike seen below is the http request, roughly 800MB for all the keys.