Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto V2 fixes #1630

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Crypto V2 fixes #1630

merged 1 commit into from
Nov 8, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Nov 7, 2022

A number of changes / fixes for Crypto V2:

  • re-decrypt events by specific sessionId after importing keys
  • ensure we send room keys to our other devices
  • better location for mac-specific crypto store (useful in integration tests)
  • enable isUntrusted state for events
  • fix a few nullability crashes

@Anderas Anderas requested review from a team and stefanceriu and removed request for a team November 7, 2022 16:46
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 36.22% // Head: 25.40% // Decreases project coverage by -10.81% ⚠️

Coverage data is based on head (ceae266) compared to base (d70c5af).
Patch coverage: 5.17% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1630       +/-   ##
============================================
- Coverage    36.22%   25.40%   -10.82%     
============================================
  Files          582      582               
  Lines        92316    92348       +32     
  Branches     40130    40050       -80     
============================================
- Hits         33444    23465     -9979     
- Misses       57872    68107    +10235     
+ Partials      1000      776      -224     
Impacted Files Coverage Δ
...o/Algorithms/RoomEvent/MXRoomEventDecryption.swift 0.00% <0.00%> (-68.84%) ⬇️
...trixSDK/Crypto/CrossSigning/MXCrossSigningV2.swift 0.00% <0.00%> (-21.25%) ⬇️
...trixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift 0.00% <0.00%> (ø)
...chine/MXEventDecryptionResult+DecryptedEvent.swift 0.00% <0.00%> (-88.24%) ⬇️
...pto/KeyBackup/Engine/MXCryptoKeyBackupEngine.swift 0.00% <0.00%> (-48.91%) ⬇️
MatrixSDK/Crypto/MXCryptoV2.swift 0.81% <0.00%> (+<0.01%) ⬆️
...ms/RoomEvents/MXRoomEventDecryptionUnitTests.swift 0.00% <0.00%> (-98.64%) ⬇️
...s/Crypto/CryptoMachine/MXCryptoProtocolStubs.swift 0.00% <0.00%> (-51.32%) ⬇️
...sts/Crypto/Data/MXMegolmSessionDataUnitTests.swift 0.00% <0.00%> (-95.39%) ⬇️
...ckup/Engine/MXCryptoKeyBackupEngineUnitTests.swift 0.00% <0.00%> (-89.84%) ⬇️
... and 206 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Anderas Anderas merged commit 21a8dfa into develop Nov 8, 2022
@Anderas Anderas deleted the andy/crypto_fixes branch November 8, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants