Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove megolm decrypt cache build flag #1606

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Remove megolm decrypt cache build flag #1606

merged 1 commit into from
Oct 17, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Oct 13, 2022

After a brief stabilization period with the cache variant set to YES, we can now remove the flag altogether

@Anderas Anderas requested review from a team and gileluard and removed request for a team October 13, 2022 10:34
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 15.91% // Head: 15.91% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2a08b43) compared to base (d46bc7b).
Patch coverage: 23.07% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1606      +/-   ##
===========================================
- Coverage    15.91%   15.91%   -0.01%     
===========================================
  Files          575      575              
  Lines        91034    91010      -24     
  Branches     38394    38380      -14     
===========================================
- Hits         14492    14488       -4     
+ Misses       76075    76055      -20     
  Partials       467      467              
Impacted Files Coverage Δ
MatrixSDK/MXSDKOptions.m 100.00% <ø> (ø)
MatrixSDK/MXSession.m 7.96% <ø> (+0.01%) ⬆️
MatrixSDK/Crypto/MXOlmDevice.m 22.94% <23.07%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Anderas Anderas merged commit aed6ebb into develop Oct 17, 2022
@Anderas Anderas deleted the andy/megolm_cache branch October 17, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants