Add extra logging and always cancel eventStreamRequest before setting to nil #1597
Conversation
| MXLogErrorDetails(@"[MXSession] handleServerSyncError: sync fail is handled by caller, resetting eventStreamRequest might not be handled", @{ | ||
| @"error": error ?: @"unknown" | ||
| }); |
There was a problem hiding this comment.
@ismailgulek WDYT about this bit ? If the error is a timeout and failure != nil, the eventStreamRequest might not be reset 🤔
There was a problem hiding this comment.
Yeah you right. It even makes sense to reset the request here regardless of failure block.
Codecov ReportBase: 13.48% // Head: 13.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1597 +/- ##
===========================================
- Coverage 13.48% 13.48% -0.01%
===========================================
Files 541 541
Lines 86690 86702 +12
Branches 36828 36835 +7
===========================================
+ Hits 11693 11694 +1
- Misses 74555 74566 +11
Partials 442 442
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| MXLogErrorDetails(@"[MXSession] handleServerSyncError: sync fail is handled by caller, resetting eventStreamRequest might not be handled", @{ | ||
| @"error": error ?: @"unknown" | ||
| }); |
There was a problem hiding this comment.
Yeah you right. It even makes sense to reset the request here regardless of failure block.
Extra logging for element-hq/element-ios#6614 issue