Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatted_body content for unformatted events #1529

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

aringenbach
Copy link
Contributor

Fixes element-hq/element-ios#6446

The formatted_body content is now properly omitted if there is no actual formatting within the message (same behaviour as Web).

@aringenbach aringenbach requested a review from stefanceriu July 18, 2022 14:55
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

MatrixSDK/Aggregations/MXAggregatedEditsUpdater.m Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1529 (2a899ff) into develop (b83b814) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1529      +/-   ##
===========================================
- Coverage    12.04%   12.04%   -0.01%     
===========================================
  Files          512      512              
  Lines        83822    83825       +3     
  Branches     35786    35788       +2     
===========================================
  Hits         10097    10097              
- Misses       73357    73360       +3     
  Partials       368      368              
Impacted Files Coverage Δ
MatrixSDK/Aggregations/MXAggregatedEditsUpdater.m 7.36% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83b814...2a899ff. Read the comment docs.

@aringenbach aringenbach merged commit f6f1f15 into develop Jul 18, 2022
@aringenbach aringenbach deleted the aringenbach/6446_fix_formatted_body_content branch July 18, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"formatted_body" is set to "* (null)" when editing messages
3 participants