SP4: Space Settings #1385
Merged
SP4: Space Settings #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `extractLocalAliasPart` method
- Added changelog
- Updates after review
stefanceriu
requested changes
Mar 4, 2022
|
|
||
| /// Extract the valid local alias part String of the string ((e.g. "my_alias" for the string "#my_alias:example.org") | ||
| /// - Returns:the valid local alias part extracted from the string. | ||
| func extractLocalAliasPart() -> String { |
There was a problem hiding this comment.
I'm not sure I like these methods being available on any kind of string. Is there a way to limit them to aliases? Maybe move them to MXTools and have them receive the string from the outside?
|
|
||
| FOUNDATION_EXPORT NSString *const kMXJoinRulesContentKeyAllow; | ||
| FOUNDATION_EXPORT NSString *const kMXJoinRulesContentKeyType; | ||
| FOUNDATION_EXPORT NSString *const kMXJoinRulesContentKeyRoomId; |
- Updates after review
- Make CI happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for element-hq/element-ios#5233