Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Towncrier #1181

Merged
merged 22 commits into from
Aug 5, 2021
Merged

Enable Towncrier #1181

merged 22 commits into from
Aug 5, 2021

Conversation

manuroe
Copy link
Contributor

@manuroe manuroe commented Aug 4, 2021

SDK part for element-hq/element-ios#4393

Other repos will have the same towncrier template. They will have a link to the updated CONTRIBUTING.md file of this SDK repo.

$ towncrier build --draft --version 1.2.3

returns with this PR:

Changes in 1.2.3 (2021-08-04)

🐛 Bugfixes

  • Tests: Fix a crash in various tests from a missing storeMaxUploadSize method. (#1175)

🧱 Build

  • CHANGES.md: Use towncrier to manage the change log. More info in CONTRIBUTING. (#4393)

📄 Documentation

  • Convert CHANGES and CONTRIBUTING to MarkDown. (#4393)

@pixlwave
Copy link
Member

pixlwave commented Aug 5, 2021

Looks great to me!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manuroe manuroe merged commit ac4f070 into develop Aug 5, 2021
@manuroe manuroe deleted the manu/4393_towncrier2 branch August 5, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants