Remove commented device property from push rules.

It's an un-specced property and will be removed per matrix-org/synapse#12482
matrix-org · Jan 9, 2023 · da412bc · da412bc
1 parent 983ad0f
commit da412bc
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 9 deletions.
diff --git a/MatrixSDK/JSONModels/MXJSONModels.h b/MatrixSDK/JSONModels/MXJSONModels.h
@@ -778,18 +778,12 @@ FOUNDATION_EXPORT NSString *const kMXPushRuleConditionStringSenderNotificationPe
  Push rule scope definitions - String version
  */
 FOUNDATION_EXPORT NSString *const kMXPushRuleScopeStringGlobal;
-FOUNDATION_EXPORT NSString *const kMXPushRuleScopeStringDevice;
 
 /**
  `MXPushRulesResponse` represents the response to the /pushRules/ request.
  */
 @interface MXPushRulesResponse : MXJSONModel
 
-    /**
-     Set of push rules specific per device.
-     */
-    // @property (nonatomic) NSDictionary *device;
-
     /**
      Set of global push rules.
      */

diff --git a/MatrixSDK/JSONModels/MXJSONModels.m b/MatrixSDK/JSONModels/MXJSONModels.m
@@ -833,7 +833,6 @@ @interface MXPushRulesResponse ()
 @implementation MXPushRulesResponse
 
 NSString *const kMXPushRuleScopeStringGlobal = @"global";
-NSString *const kMXPushRuleScopeStringDevice = @"device";
 
 + (id)modelFromJSON:(NSDictionary *)JSONDictionary
 {
@@ -845,8 +844,6 @@ + (id)modelFromJSON:(NSDictionary *)JSONDictionary
             pushRulesResponse.global = [MXPushRulesSet modelFromJSON:JSONDictionary[kMXPushRuleScopeStringGlobal] withScope:kMXPushRuleScopeStringGlobal];
         }
 
-        // TODO support device rules
-
         pushRulesResponse->JSONDictionary = JSONDictionary;
     }
 

diff --git a/changelog.d/pr-1677.change b/changelog.d/pr-1677.change
@@ -0,0 +1 @@
+Remove commented device property on MXPushRulesRespose.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Remove commented device property on MXPushRulesRespose.