Allow notifications to "Deliver Quietly"

CHANGES.rst

@@ -12,7 +12,7 @@ Changes to be released in next version
  * MXKRoomViewController: Fix initial timeline position when viewing a room for the second time.
 
 ⚠️ API Changes
- * 
+ * MXKAccountManager: `isAPNSAvailable` and `isPushAvailable` now only indicate the availability of notifications and not their visibility as well (vector-im/element-ios/issues/2368).
 
 🗣 Translations
  * 

MatrixKit/Models/Account/MXKAccountManager.h

@@ -70,7 +70,7 @@ extern NSString *const MXKAccountManagerDataType;
 @property (nonatomic, copy) NSData *apnsDeviceToken;
 
 /**
- The APNS status: YES when app is registered for remote notif, and devive token is known.
+ The APNS status: YES when app is registered for remote notif, and device token is known.
  */
 @property (nonatomic) BOOL isAPNSAvailable;
 

MatrixKit/Models/Account/MXKAccountManager.m

@@ -428,19 +428,15 @@ - (void)setApnsDeviceToken:(NSData *)apnsDeviceToken
 - (BOOL)isAPNSAvailable
 {
     // [UIApplication isRegisteredForRemoteNotifications] tells whether your app can receive
-    // remote notifications or not. However receiving remote notifications does not mean it
-    // will also display them to the user.
-    // To check whether the user allowed or denied remote notification or in fact changed
-    // the notifications permissions later in iOS setting, we have to call
-    // [UIApplication currentUserNotificationSettings].
+    // remote notifications or not. Receiving remote notifications does not guarantee it will
+    // display them to the user as they may have notifications set to deliver quietly.
 
     BOOL isRemoteNotificationsAllowed = NO;
 
     UIApplication *sharedApplication = [UIApplication performSelector:@selector(sharedApplication)];
     if (sharedApplication)
     {
-        UIUserNotificationSettings *settings = [sharedApplication currentUserNotificationSettings];
-        isRemoteNotificationsAllowed = (settings.types != UIUserNotificationTypeNone);
+        isRemoteNotificationsAllowed = [sharedApplication isRegisteredForRemoteNotifications];
 
         MXLogDebug(@"[MXKAccountManager][Push] isAPNSAvailable: The user %@ remote notification", (isRemoteNotificationsAllowed ? @"allowed" : @"denied"));
     }
@@ -572,19 +568,15 @@ - (void)setPushDeviceToken:(NSData *)pushDeviceToken withPushOptions:(NSDictiona
 - (BOOL)isPushAvailable
 {
     // [UIApplication isRegisteredForRemoteNotifications] tells whether your app can receive
-    // remote notifications or not. However receiving remote notifications does not mean it
-    // will also display them to the user.
-    // To check whether the user allowed or denied remote notification or in fact changed
-    // the notifications permissions later in iOS setting, we have to call
-    // [UIApplication currentUserNotificationSettings].
+    // remote notifications or not. Receiving remote notifications does not guarantee it will
+    // display them to the user as they may have notifications set to deliver quietly.
 
     BOOL isRemoteNotificationsAllowed = NO;
 
     UIApplication *sharedApplication = [UIApplication performSelector:@selector(sharedApplication)];
     if (sharedApplication)
     {
-        UIUserNotificationSettings *settings = [sharedApplication currentUserNotificationSettings];
-        isRemoteNotificationsAllowed = (settings.types != UIUserNotificationTypeNone);
+        isRemoteNotificationsAllowed = [sharedApplication isRegisteredForRemoteNotifications];
 
         MXLogDebug(@"[MXKAccountManager][Push] isPushAvailable: The user %@ remote notification", (isRemoteNotificationsAllowed ? @"allowed" : @"denied"));
     }