Use yaml.safe_load instead of yaml.load in check-event-schema-examples.py
#3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyYAML 6.0 [requires](yaml/pyyaml#561) a Loader argument to be passed to yaml.load. We could pass yaml.SafeLoader, or simply use the yaml.safe_load method instead. This PR opts to do the latter for simplicity. The previous default loader was yaml.Loader, and as such this PR changes the behaviour to yaml.SafeLoader. I don't think this has any actual repurcussions on the data that we're loading in however. https://msg.pyyaml.org/load has more details, and even recommends that FullLoader no longer be used.
KitsuneRal
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyYAML 6.0 requires a Loader argument to be passed to yaml.load. We could pass
yaml.SafeLoader, or simply use theyaml.safe_loadmethod instead. This PR opts to do the latter for simplicity.The previous default loader was
yaml.FullLoader, and as such this PR changes the behaviour toyaml.SafeLoader. I don't think this has any actual repercussions on the data that we're loading in however. https://msg.pyyaml.org/load has more details, and even recommends thatFullLoaderno longer be used.This PR is required for this script to work with PyYAML 6.0.
Preview: https://pr3716--matrix-org-previews.netlify.app