Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for lazy-loading room members to improve initial sync speed and client RAM usage #1227

Closed
benparsons opened this issue May 10, 2018 · 28 comments
Assignees
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Comments

@benparsons
Copy link
Member

benparsons commented May 10, 2018

Documentation: https://docs.google.com/document/d/11yn-mAkYll10RJpN0mkYEVqraTbU3U4eQx9MNrzqX1U/edit
Author: @ara4n
Date: 05/03/2018
PR: #1287

@ara4n ara4n added the proposal A matrix spec change proposal label May 15, 2018
@ara4n
Copy link
Member

ara4n commented May 28, 2018

Implementation over at matrix-org/synapse#2970

@ara4n
Copy link
Member

ara4n commented Jun 10, 2018

It's worth noting that lazyloading members is entirely orthogonal to paginating the room list - in an ideal world we could end up supporting both.

@ara4n
Copy link
Member

ara4n commented Jun 10, 2018

rolling this back to proposal-review as even though there’s been informal thumbs up from @richvdh and @erikjohnston, the whole thing is blocked on #688 before it can progress to completion and the proposal should be formally reviewed in the context of #688

@richvdh
Copy link
Member

richvdh commented Aug 16, 2018

given that I've been busily merging PRs which implement this, and I gather that client-side support is likewise basically done, it seems like this is basically being treated as ready.

In other words: I'd suggest that anyone with objections makes them quickly, and it would be nice if the doc could be updated to clarify the current state.

@richvdh
Copy link
Member

richvdh commented Aug 16, 2018

@turt2live
Copy link
Member

turt2live commented Aug 20, 2018

I vote that this MSC should enter the final comment period with the view of having it be a spec PR next week. Can the Spec Core Team either approve going into FCP or comment with any concerns. Those outside the team with concerns/suggestions are also welcome to raise them.

(also this has been in review for a while now, but no one updated the labels)

@ara4n
Copy link
Member

ara4n commented Aug 20, 2018

I've been using this on riot/web + matrix.org and it seems to be working okay. People seem to have religious objections to the way it special cases members (as opposed to paginating rooms or whatever), but it seems like a good enough solution for now.

@uhoreg
Copy link
Member

uhoreg commented Aug 21, 2018

I'm going to abstain on voting due to lack of bandwidth to try to process this, and I trust that it has been sufficiently picked at by other people.

@richvdh
Copy link
Member

richvdh commented Aug 21, 2018

Again the comments need cleaning up and integrating, but at least this one is clear enough to merit entering FCP

@anoadragon453
Copy link
Member

I'm happy with this entering FCP

@turt2live turt2live added the client-server Client-Server API label Sep 5, 2018
@Half-Shot
Copy link
Contributor

Should something have happened with regards to FCPs?

@anoadragon453
Copy link
Member

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Nov 3, 2018

Team member @anoadragon453 has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Nov 3, 2018
@Half-Shot
Copy link
Contributor

Does @ara4n need to make a PR with the proposal?

@Half-Shot
Copy link
Contributor

@anoadragon453 Given the spec proposal at #1758 got merged, do we close this?

@anoadragon453
Copy link
Member

@Half-Shot Yep, and I'll update the tags.

@anoadragon453 anoadragon453 added merged A proposal whose PR has merged into the spec! finished-final-comment-period and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Mar 28, 2019
@turt2live
Copy link
Member

... it's not merged yet... there's still stuff missing.

@turt2live turt2live reopened this Mar 28, 2019
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed merged A proposal whose PR has merged into the spec! labels Mar 28, 2019
@Half-Shot
Copy link
Contributor

(my bad, I failed to read context)

@turt2live
Copy link
Member

Spec PR: #2035

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 28, 2019
@turt2live
Copy link
Member

merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 11, 2019
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Development

No branches or pull requests

9 participants