-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for lazy-loading room members to improve initial sync speed and client RAM usage #1227
Comments
Implementation over at matrix-org/synapse#2970 |
It's worth noting that lazyloading members is entirely orthogonal to paginating the room list - in an ideal world we could end up supporting both. |
rolling this back to proposal-review as even though there’s been informal thumbs up from @richvdh and @erikjohnston, the whole thing is blocked on #688 before it can progress to completion and the proposal should be formally reviewed in the context of #688 |
given that I've been busily merging PRs which implement this, and I gather that client-side support is likewise basically done, it seems like this is basically being treated as ready. In other words: I'd suggest that anyone with objections makes them quickly, and it would be nice if the doc could be updated to clarify the current state. |
(and matrix-org/synapse#3589, matrix-org/synapse#3568, matrix-org/synapse#3567 and matrix-org/synapse#3331) |
I vote that this MSC should enter the final comment period with the view of having it be a spec PR next week. Can the Spec Core Team either approve going into FCP or comment with any concerns. Those outside the team with concerns/suggestions are also welcome to raise them. (also this has been in review for a while now, but no one updated the labels) |
I've been using this on riot/web + matrix.org and it seems to be working okay. People seem to have religious objections to the way it special cases members (as opposed to paginating rooms or whatever), but it seems like a good enough solution for now. |
I'm going to abstain on voting due to lack of bandwidth to try to process this, and I trust that it has been sufficiently picked at by other people. |
Again the comments need cleaning up and integrating, but at least this one is clear enough to merit entering FCP |
I'm happy with this entering FCP |
Should something have happened with regards to FCPs? |
@mscbot fcp merge |
Team member @anoadragon453 has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
Does @ara4n need to make a PR with the proposal? |
@anoadragon453 Given the spec proposal at #1758 got merged, do we close this? |
@Half-Shot Yep, and I'll update the tags. |
... it's not merged yet... there's still stuff missing. |
(my bad, I failed to read context) |
Spec PR: #2035 |
merged 🎉 |
Documentation: https://docs.google.com/document/d/11yn-mAkYll10RJpN0mkYEVqraTbU3U4eQx9MNrzqX1U/edit
Author: @ara4n
Date: 05/03/2018
PR: #1287
The text was updated successfully, but these errors were encountered: