Double bridging rule files #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Otherwise LGTM, pending matrix-org/matrix-appservice-bridge#85
rules.sample.yaml
Outdated
| @@ -0,0 +1,10 @@ | |||
| # A set of regexes to match against joined members in rooms. | |||
There was a problem hiding this comment.
This file should probably have a more descriptive name, like 'provisioning.rules.sample.yaml'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: matrix-org/matrix-appservice-bridge#85
This change allows you to do rule specifying on what is allowed to be provisioned to avoid some cases of double bridging. New provision requests would check against the rule file to see if the members in a certain room were excluded from being bridged e.g. not mixing "@snoonet-irc:matrix.org" and "@gimpnet-irc:matrix.org" in the same room.
This doesn't yet affect existing bridged rooms, which would need us to manually intervene.