Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of number of connections in an integer #530

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 8, 2017

Rather than filtering a list each time. This is pretty slow.

Rather than filtering a list each time. This is pretty slow.
@dbkr dbkr assigned ara4n and richvdh and unassigned ara4n Dec 8, 2017
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment somewhere as to why we are doing this would be helpful, else somebody is going to come along and "optimise" it by undoing all this.

LGTM otherwise

@richvdh richvdh assigned dbkr and unassigned richvdh Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants