Make ident address configurable #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegsay
reviewed
May 19, 2017
lib/irc/ident.js
Outdated
| @@ -20,7 +20,8 @@ var net = require('net'); | |||
| var log = require("../logging").get("irc-ident"); | |||
|
|
|||
| var config = { | |||
| port: 113 | |||
| port: 113, | |||
| adddress: "0.0.0.0" | |||
kegsay
reviewed
May 19, 2017
| @@ -321,6 +321,9 @@ ircService: | |||
| # on instead of 113 here. | |||
| # Default: 113. | |||
| port: 1113 | |||
| # The address to listen on for incoming ident requests. | |||
| # Default: 0.0.0.0 | |||
| address: "::" | |||
There was a problem hiding this comment.
If you run this on a machine which does not support IPv6, does this work? I suspect it will fall over, so I would prefer if this value were set to "0.0.0.0" instead. The docs aren't super clear either way.
There was a problem hiding this comment.
:: binds for both IPv6 and IPv4 on most operating systems (including Linux and macOS). In which case this works on a machine that doesn't have an IPv6 address.
Also see the conversation for matrix-org/synapse#2232.
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration option for the listen address for incoming ident requests.