Check dropMatrixMessagesAfterSecs just before sending to IRC #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to handle cases where it is set to drop messages after 5 minutes, the message arrives at 4m30s and it takes 1 minute to go through the bridge (establish connection, join channel, etc). Previously, the message would go through, 5m30s after the initial send. Now, it won't go through.
lib/irc/IrcServer.js
Outdated
| * @param {string} homeserverDomain : The domain of the homeserver | ||
| * e.g "matrix.org" | ||
| * @param {Number} expiryTimeSeconds : The max number of seconds a | ||
| * message can be in order for it to be sent to this server. |
There was a problem hiding this comment.
I'm not sure this makes sense. What does "a message can be" mean?
lib/irc/IrcServer.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Get the max number of seconds a message can be before it is dropped from |
There was a problem hiding this comment.
again, I'm not sure this is phrased well, see above.
spec/integ/matrix-to-irc.spec.js
Outdated
| let connected = false; | ||
| env.ircMock._whenClient(roomMapping.server, testUser2.nick, "connect", | ||
| function(client, cb) { | ||
| jasmine.clock().tick(20 * 1000); // advance 20s to take it over the drop time |
There was a problem hiding this comment.
I would make it obvious that "drop time" is actually dropMatrixMessagesAfterSecs
|
Aren't you still missing the word "old"? As in, |
|
Yep, I've re-phrased with "old" already: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle cases where it is set to drop messages after
5 minutes, the message arrives at 4m30s and it takes 1 minute
to go through the bridge (establish connection, join channel, etc).
Previously, the message would go through, 5m30s after the initial
send. Now, it won't go through.
Fixes issues mentioned in #388 by @justjanne